RFR: 8365501: Remove special AdapterHandlerEntry for abstract methods [v3]

Andrew Dinn adinn at openjdk.org
Mon Sep 1 10:31:43 UTC 2025


On Wed, 27 Aug 2025 19:35:04 GMT, Ashutosh Mehra <asmehra at openjdk.org> wrote:

>> This PR removes the need for having AdapterHandlerEntry for abstract methods. The check for abstract method is now done in the accessor functions in Method such as Method::get_i2c_entry().
>> Motivation for this change is described in the JBS issue.
>
> Ashutosh Mehra has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address review comment - swap conditions
>   
>   Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>

Looks good but I would appreciate an explanation as to why we don't need the lock.

src/hotspot/share/runtime/sharedRuntime.cpp line 2567:

> 2565:   {
> 2566:     ResourceMark rm;
> 2567:     MutexLocker mu(AdapterHandlerLibrary_lock);

Why are we ok to drop this lock here? Was it unnecessary even before this change?

-------------

Marked as reviewed by adinn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/26764#pullrequestreview-3173094876
PR Review Comment: https://git.openjdk.org/jdk/pull/26764#discussion_r2313562473


More information about the hotspot-dev mailing list