RFR: 8366238: Improve RBTree API with stricter comparator semantics and pluggable validation/printing hooks. [v3]

Casper Norrbin cnorrbin at openjdk.org
Mon Sep 1 13:40:29 UTC 2025


On Mon, 1 Sep 2025 09:08:00 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Casper Norrbin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   albert feedback
>
> src/hotspot/share/utilities/rbTree.hpp line 133:
> 
>> 131:               size_t& tree_depth, bool expect_visited, NodeVerifier verifier,
>> 132:               const USER_VERIFIER& extra_verifier) const;
>> 133: 
> 
> `NodeType` is unused. Here we have two different naming standards for the template name.

`NodeType` is used in the inline file so is needed. Renamed `NodeVerifier` to `NODE_VERIFIER` to fit in with the other templates.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26981#discussion_r2313988884


More information about the hotspot-dev mailing list