RFR: 8366474: Rename MetaspaceObj::is_shared() to MetaspaceObj::in_aot_cache() [v2]

[Ioi Lam]

On Sat, 30 Aug 2025 17:34:38 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> This PR is one (of many) steps in [JDK-8366473](https://bugs.openjdk.org/browse/JDK-8366473) (Refactor CDS source code with new AOT terminology):
>> 
>> Rename `is_shared()` in `Metaspace` (and various other classes) to `in_aot_cache()` to reflect its true meaning:
>> - tests if an object is inside the AOT cache's metaspace region.
>> 
>> Also various forms of  "shared metaspace" are updated to "aot metaspace"
>> 
>> Please start your review with allocations.hpp
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed MetaspaceShared -> AOTMetaspace changes that are intended for https://github.com/openjdk/jdk/pull/27017

I've merged with the mainline to resolve conflicts.

I also made one extra fix: `ConstantPool::is_shared()` was shadowing `MetaspaceObj::is_shared()`, so I renamed it to `in_aot_cache()`, so that it will now shadow `MetaspaceObj::in_aot_cache()`. See [17f8c0b](https://github.com/openjdk/jdk/pull/27016/commits/17f8c0bfe302504cd027435fa92cdc58f3362f7c)

@vnkozlov @liach could you re-review?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/27016#issuecomment-3251598867