RFR: 8365190: Remove LockingMode related code from share

Fredrik Bredberg fbredberg at openjdk.org
Thu Sep 4 09:48:45 UTC 2025


On Thu, 4 Sep 2025 02:16:46 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> src/hotspot/share/runtime/basicLock.hpp line 51:
>> 
>>> 49:   void set_bad_metadata_deopt() { set_metadata(badDispHeaderDeopt); }
>>> 50: 
>>> 51:   static int displaced_header_offset_in_bytes() { return metadata_offset_in_bytes(); }
>> 
>> Also delete line 51 ?
>
> Still appears used in LIRAssembler. But the assert in which it is used doesn't really make sense as it just checks the offset == 0.

This is unfortunately still used by some of the platform files. Since I want to keep this PR clean of platform changes, I have added this to the [next cleanup](https://bugs.openjdk.org/browse/JDK-8365191).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27041#discussion_r2321466475


More information about the hotspot-dev mailing list