RFR: 8366363: MemBaseline accesses VMT without using lock [v12]

Casper Norrbin cnorrbin at openjdk.org
Thu Sep 4 09:57:49 UTC 2025


On Wed, 3 Sep 2025 09:12:44 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Hi,
>> 
>> The `MemBaseline` used to access the VMT instance directly without a lock. We fix that, and we switch from using a `LinkedList` to a copied `RegionsTree` instead.
>
> Johan Sjölen has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 16 commits:
> 
>  - Merge remote-tracking branch 'openjdk/master' into cleanup-membaseline
>  - Rename to _vma_allocations
>  - After a lot of casting
>  - Yup
>  - Some more ugly casts
>  - Aha, _root is typed as an IntrusiveRBNode
>  - Aha, missing include
>  - Wait, the VMATree is wrong?
>  - Rename
>  - It's const
>  - ... and 6 more: https://git.openjdk.org/jdk/compare/6dda2f6f...82df750b

src/hotspot/share/utilities/rbTree.hpp line 457:

> 455:   ~RBTree() { remove_all(); }
> 456: 
> 457:   bool copy_into(RBTree& other) const {

Could you move this function into `rbTree.inline.hpp` instead? It's a bit too big to fit here

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27003#discussion_r2321477007


More information about the hotspot-dev mailing list