RFR: 8317269: Store old classes in linked state in AOT cache [v2]
Coleen Phillimore
coleenp at openjdk.org
Thu Sep 4 19:15:46 UTC 2025
On Tue, 19 Aug 2025 23:31:19 GMT, Ioi Lam <iklam at openjdk.org> wrote:
>> src/hotspot/share/cds/dumpTimeClassInfo.cpp line 90:
>>
>>> 88: _old_verifier_dependencies = new (mtClass) GrowableArray<Symbol*>(4, mtClass);
>>> 89: }
>>> 90: _old_verifier_dependencies->append(name);
>>
>> I wonder why there's append and push that do the same thing in GrowableArray. I'm used to seeing push().
>
> I am not sure why there are two versions. They seem to be used at similar frequency (about 300 calls each).
So there's add_verification_constraint for the new verifier and add_old_verification_dependency but are these the same sort of thing? Maybe the new name should be add_old_verification_constraint.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26754#discussion_r2323100409
More information about the hotspot-dev
mailing list