RFR: 8317269: Store old classes in linked state in AOT cache [v5]

[Coleen Phillimore]

On Mon, 1 Sep 2025 00:57:36 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> I would kind of prefer old_verifier_dependency rather than old_verification - the latter seems to say that we had some verification that is no longer valid.  old_verifier makes it clearer it's for old classfiles and the old verifier.  Also 'verification' is used for the regular verifier so it's less of a same name.
>
>> The caller just did this, didn't it?
> 
> There is a different caller (SystemDictionaryShared::copy_verification_info_from_preimage) which has only the class name.
> 
>> I would kind of prefer old_verifier_dependency
>  
> The current code is kind of messy. For example, we have _verifier_constraints in DumpTimeClassInfo, but other places use "verification_constraints".
> 
> Maybe I should rename all old and new cases of verification_xxx to verifier_xxx?

That's why I'm confused, there's one in DumpTimeInfo and another one in SystemDictionaryShared.

Shouldn't this call find_{verification_dependency}_bottom_klass?  Looks like the same code.  I feel like you want to generalize this case where you try to find the underlying InstanceKlass.  And pass the class_loader rather than getting if from 'k'.   And define it in SystemDictionary under the find_instance_or_array_klass.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26754#discussion_r2323151811