RFR: 8366154: Validate thread type requirements in debug commands [v3]

Kerem Kat krk at openjdk.org
Tue Sep 9 17:19:27 UTC 2025


On Tue, 9 Sep 2025 10:19:19 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> Thank you for the description for `hasActiveThread`. Is it much different than the `onJavaThread` in the first revision?
>
> OK, I see now that I'm suggesting more like what you had originally, that you go back to what David disliked. 8-)
> 
> I would have gone for having this check in the helper method (even if it means multiple Thread::current calls) over duplication inserted into three command implementations.  Seems like a way to fix their assumptions also.
> 
> Just want to check with David if he might agree that keeping the individual commands simpler is worth permitting the additional helper method.

Thank you for the clarification! That makes sense.

I'll move forward with David's suggestion to have the duplication where the `Command` objects are used.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27033#discussion_r2334277875


More information about the hotspot-dev mailing list