RFR: 8367282: FORBID_C_FUNCTION needs exception spec consistent with library declaration

[Matthias Baesken]

On Wed, 10 Sep 2025 02:58:31 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> Please review this change to FORBID_C_FUNCTION to make the exception specs of
> the forbidding declarations match up with the exception specs of the
> associated library declarations. This needs to account for different platform
> libraries either having or not having exception specs. It's needed because,
> after switching to C++17, some compilers complain about some differences in
> the exception specs.
> 
> Also removed the workaround for JDK-8367051, which should no longer be needed
> after this change.
> 
> Hoping someone will test the aix-ppc port. @MBaesken or @TheRealMDoerr ?
> 
> Testing: mach5 tier1, GHA sanity checks (nearly finished)
> Locally (linux-aarch64) built with clang, which failed without the JDK-8367051
> workaround.

src/hotspot/share/utilities/compilerWarnings.hpp line 147:

> 145:   FORBID_C_FUNCTION(FORBIDDEN_FUNCTION_IMPORT_SPEC Signature, Noexcept, Alternative)
> 146: 
> 147: #define FORBID_NORETURN_C_FUNCTION(Signature, Noexcept, Alternative)    \

Is the added whitespace after ')' intended ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27180#discussion_r2335886801