RFR: 8367320: Sort cpu/x86 includes [v2]

Albert Mingkun Yang ayang at openjdk.org
Wed Sep 10 15:50:38 UTC 2025


On Wed, 10 Sep 2025 14:50:21 GMT, Francesco Andreuzzi <duke at openjdk.org> wrote:

>> Sort includes in `cpu/x86` using `SortIncludes.java`. I'm also removing a couple unnecessary ones.
>> 
>> Passes `tier1` and `tier2`.
>
> Francesco Andreuzzi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   inline stuff

src/hotspot/cpu/x86/continuationHelper_x86.inline.hpp line 29:

> 27: 
> 28: #include "runtime/continuationEntry.inline.hpp"
> 29: #include "runtime/continuationHelper.hpp"

I think this is another case where the intention was that `continuationHelper.hpp` is the corresponding hpp and should be placed at the top.

I wonder if the script should/can be revised a bit to recognize this pattern.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27189#discussion_r2337196317


More information about the hotspot-dev mailing list