RFR: 8367137: RISC-V: Detect Zicboz block size via hwprobe [v4]

Dingli Zhang dzhang at openjdk.org
Thu Sep 11 00:11:36 UTC 2025


On Wed, 10 Sep 2025 09:16:19 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Dingli Zhang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Replace CacheLineSize with zicboz_block_size in block zeroing logic
>
> src/hotspot/cpu/riscv/macroAssembler_riscv.cpp line 5877:
> 
>> 5875: //
>> 5876: // NOTE: This is intended to be used in the zero_blocks() stub.  If
>> 5877: // you want to use it elsewhere, note that cnt must be no less than zicboz block size.
> 
> previous style is more readable, like:
> 
>>= zicboz_block_size

Fixed.

> src/hotspot/os_cpu/linux_riscv/riscv_hwprobe.cpp line 91:
> 
>> 89: #define   RISCV_HWPROBE_MISALIGNED_UNSUPPORTED  (4 << 0)
>> 90: #define   RISCV_HWPROBE_MISALIGNED_MASK         (7 << 0)
>> 91: #define RISCV_HWPROBE_KEY_ZICBOZ_BLOCK_SIZE 6
> 
> better to have a new line.

Thanks for the review!
Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27155#discussion_r2338203476
PR Review Comment: https://git.openjdk.org/jdk/pull/27155#discussion_r2338203353


More information about the hotspot-dev mailing list