RFR: 8367282: FORBID_C_FUNCTION needs exception spec consistent with library declaration [v2]

[David Holmes]

On Thu, 11 Sep 2025 04:11:29 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Please review this change to FORBID_C_FUNCTION to make the exception specs of
>> the forbidding declarations match up with the exception specs of the
>> associated library declarations. This needs to account for different platform
>> libraries either having or not having exception specs. It's needed because,
>> after switching to C++17, some compilers complain about some differences in
>> the exception specs.
>> 
>> Also removed the workaround for JDK-8367051, which should no longer be needed
>> after this change.
>> 
>> Hoping someone will test the aix-ppc port. @MBaesken or @TheRealMDoerr ?
>> 
>> Testing: mach5 tier1, GHA sanity checks (nearly finished)
>> Locally (linux-aarch64) built with clang, which failed without the JDK-8367051
>> workaround.
>
> Kim Barrett has updated the pull request incrementally with one additional commit since the last revision:
> 
>   work around AIX noexcept inconsistencies

src/hotspot/share/utilities/compilerWarnings.hpp line 122:

> 120:     [[deprecated(Alternative)]]                                 \
> 121:     Signature                                                   \
> 122:     /* 2-step pasting to avoid expansion of FFCN => nothing. */ \

Was this an issue with AIX or is this just a "better" way?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27180#discussion_r2338695490