RFR: 8367368: Add message for verify_legal_class_modifiers for inner classes [v3]

Coleen Phillimore coleenp at openjdk.org
Thu Sep 11 12:57:50 UTC 2025


On Thu, 11 Sep 2025 02:15:06 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add comment about illegal modifier flags.
>
> src/hotspot/share/classfile/vmSymbols.hpp line 515:
> 
>> 513:   template(lockStackSize_name,                        "lockStackSize")                            \
>> 514:   template(objectWaiter_name,                         "objectWaiter")                             \
>> 515:   template(unnamed_name,                              "unnamed")                                  \
> 
> Shouldn't this use "anonymous" rather than "unnamed"?

static String msg2 = "Illegal class modifiers in inner class anonymous of class OuterTest2: 0x63F";

Maybe it needs some brackets or notations or something like [anonymous] or {anonymous}.  It probably would be good to have all names in hotspot error messages have '`' notation but I'm not going to change that here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27201#discussion_r2340721984


More information about the hotspot-dev mailing list