RFR: 8359104: gc/TestAlwaysPreTouchBehavior.java#<gcname> fails on Linux [v3]
Andreas Steiner
asteiner at openjdk.org
Thu Sep 11 14:32:22 UTC 2025
On Wed, 10 Sep 2025 14:32:54 GMT, Francesco Andreuzzi <fandreuzzi at openjdk.org> wrote:
>> Andreas Steiner has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Changed num_found and num_values to size_t, do the null-check right after the fopen and return early, eliminated the variable shadowing of info
>
> src/hotspot/os/linux/os_linux.cpp line 2377:
>
>> 2375: bool os::Linux::query_accurate_process_memory_info(os::Linux::accurate_meminfo_t* info) {
>> 2376: FILE* f = os::fopen("/proc/self/smaps_rollup", "r");
>> 2377: const int num_values = sizeof(os::Linux::accurate_meminfo_t) / sizeof(size_t);
>
> Should this and `num_found` be `size_t`?
Even this was copied from the existing query_process_memory_info I adapted this now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27192#discussion_r2341147963
More information about the hotspot-dev
mailing list