RFR: 8367368: Add message for verify_legal_class_modifiers for inner classes [v5]

Coleen Phillimore coleenp at openjdk.org
Fri Sep 12 12:08:19 UTC 2025


On Thu, 11 Sep 2025 00:37:36 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Only test for message fragments - Chen's comments.
>
> test/hotspot/jtreg/runtime/InnerClassesAttr/TestInnerClassAccessFlagErrorMessage.java line 58:
> 
>> 56:         } catch (ClassFormatError err) {
>> 57:             System.out.println(err.getMessage());
>> 58:             assertEquals(err.getMessage(), msg2);
> 
> I recommend testing against message fragment to ensure the class name is included without asserting the whole message, to allow more freedom in error messages while retaining desired info.

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27201#discussion_r2344035687


More information about the hotspot-dev mailing list