RFR: 8367320: Sort cpu/x86 includes [v2]

Francesco Andreuzzi fandreuzzi at openjdk.org
Fri Sep 12 13:31:14 UTC 2025


On Fri, 12 Sep 2025 13:12:43 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> I'm going to open a PR with a small change in `style-guide.md` to start the discussion.
>
> Just note that we currently don't have a consistent way that we structure the inclusions of our the platform dependent files. When making the patch that followed the  "corresponding .hpp" rule I had to handle the includes on case-by-case basis. Just be warned that you might create a rule that we can't adhere to without rewriting some of the includes patterns.

Hi @stefank, I've just opened #27259.

> Just be warned that you might create a rule that we can't adhere to without rewriting some of the includes patterns.

What do you mean? Do you have an example?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27189#discussion_r2344267959


More information about the hotspot-dev mailing list