RFR: 8366716: Move SmapsParser from runtime/os/TestTracePageSizes.java into testlib [v2]
Stefan Johansson
sjohanss at openjdk.org
Mon Sep 15 06:53:13 UTC 2025
On Sun, 14 Sep 2025 10:02:45 GMT, jonghoonpark <duke at openjdk.org> wrote:
>> related jira issue: https://bugs.openjdk.org/browse/JDK-8366716
>>
>> ---
>>
>> Following the direction outlined in the issue description,
>> I've extracted the common parts from `TestTracePageSizes` and `TestTransparentHugePagesHeap` to implement the `SmapsParser` test library.
>>
>> I've confirmed that it works without issues in my local tests.
>>
>> Reviews and feedback are welcome.
>
> jonghoonpark has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
>
> Refactor: Introduce SmapsParser
>
> Signed-off-by: jonghoonpark <dev at jonghoonpark.com>
Changes requested by sjohanss (Reviewer).
test/hotspot/jtreg/gc/TestTransparentHugePagesHeap.java line 61:
> 59: import jdk.test.lib.process.ProcessTools;
> 60: import jdk.test.lib.Platform;
> 61: import jdk.test.lib.SmapsParser;
Should be located in: `jdk.test.lib.os.linux`
-------------
PR Review: https://git.openjdk.org/jdk/pull/27273#pullrequestreview-3223133659
PR Review Comment: https://git.openjdk.org/jdk/pull/27273#discussion_r2348030096
More information about the hotspot-dev
mailing list