RFR: 8367103: RISC-V: store cpu features in a bitmap [v3]

Hamlin Li mli at openjdk.org
Mon Sep 15 13:07:39 UTC 2025


On Mon, 15 Sep 2025 08:44:16 GMT, Fei Yang <fyang at openjdk.org> wrote:

> Hi, I like the idea of separating the two group of flags. I am having a look. BTW: Can you merge and rebase?

Thank you for having a look.

> src/hotspot/cpu/riscv/vm_version_riscv.hpp line 295:
> 
>> 293:     }
>> 294: 
>> 295:     static int index(RVFeatureIndex feature) {
> 
> Seems better to rename this to `element_index`?

fixed

> src/hotspot/cpu/riscv/vm_version_riscv.hpp line 333:
> 
>> 331:     }
>> 332: 
>> 333:     bool supports_feature(uint32_t feature) {
> 
> Should this be `support_feature` like its friends `set_feature` or `clear_feature` in style?

fixed

-------------

PR Comment: https://git.openjdk.org/jdk/pull/27152#issuecomment-3292064020
PR Review Comment: https://git.openjdk.org/jdk/pull/27152#discussion_r2348929010
PR Review Comment: https://git.openjdk.org/jdk/pull/27152#discussion_r2348928552


More information about the hotspot-dev mailing list