RFR: 8366865: Allocation GC Pauses Triggered after JVM has started shutdown [v4]
Ivan Walulya
iwalulya at openjdk.org
Tue Sep 16 12:17:05 UTC 2025
On Tue, 16 Sep 2025 11:06:58 GMT, Jonas Norlinder <duke at openjdk.org> wrote:
>> Ivan Walulya has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Revert
>
> src/hotspot/share/memory/universe.cpp line 1347:
>
>> 1345:
>> 1346: void Universe::before_exit() {
>> 1347: log_cpu_time();
>
> Why did you move `log_cpu_time()`? During the review of CPUTimeUsage refactor (https://github.com/openjdk/jdk/pull/26621) we discussed this choice. Given that it still includes more than just GC I think it should stay in `Universe`. Also the PR title does not reflect that it would include a refactor of CPUTimeUsage.
Main reason was to have the `log_cpu_time` and `AtomicAccess::release_store(&_is_shutting_down, true)` under same critical section. Otherwise, we have no guarantee that we don't continue GCs after `log_cpu_time`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27190#discussion_r2352287921
More information about the hotspot-dev
mailing list