RFR: 8367103: RISC-V: store cpu features in a bitmap [v3]

Hamlin Li mli at openjdk.org
Wed Sep 17 08:18:29 UTC 2025


On Wed, 17 Sep 2025 07:46:51 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   refine
>
> src/hotspot/cpu/riscv/vm_version_riscv.hpp line 258:
> 
>> 256:   decl(mimpid           ,  ImpId           ,  RV_NO_FLAG_BIT,  false,  NO_UPDATE_DEFAULT)                  \
>> 257:   decl(satp_mode        ,  SATP            ,  RV_NO_FLAG_BIT,  false,  NO_UPDATE_DEFAULT)                  \
>> 258:   decl(zicboz_block_size, "ZicbozBlockSize",  RV_NO_FLAG_BIT,  false,  NO_UPDATE_DEFAULT)                  \
> 
> Hmm, why is this `"ZicbozBlockSize"` different from friends? Do we need the double quotes?

It's a typo when merging master, thanks for catching!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27152#discussion_r2354700767


More information about the hotspot-dev mailing list