RFR: 8366865: Allocation GC Pauses Triggered after JVM has started shutdown [v5]
Thomas Schatzl
tschatzl at openjdk.org
Wed Sep 17 09:51:44 UTC 2025
On Tue, 16 Sep 2025 12:35:38 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:
>> Please review this patch to skip VM_GC_Collect_Operations if initiated after the VM shutdown process has begun. We add a _is_shutting_down flag to CollectedHeap, which is set while holding the Heap_lock. This ensures mutual exclusion with VM_GC_Collect_Operations, which also require the Heap_lock.
>>
>> Skipping VM_GC_Collect_Operation would otherwise cause allocation requests to fail (resulting in OutOfMemoryError) if requesting daemon threads were allowed to continue, we instead block these threads on a monitor. They remain stalled until they are terminated as part of the VM shutdown sequence.
>>
>> Testing: Tier 1-7
>
> Ivan Walulya has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:
>
> - Merge remote-tracking branch 'upstream/master' into shutting_down_gcs
> - Revert
> - Thomas Review
> - return on timeout
> - Merge remote-tracking branch 'upstream/master' into shutting_down_gcs
> - timed wait
> - Merge remote-tracking branch 'upstream/master' into shutting_down_gcs
> - space
> - remove debug logs
> - remove debug logs
> - ... and 2 more: https://git.openjdk.org/jdk/compare/67035a45...edad0efe
Marked as reviewed by tschatzl (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/27190#pullrequestreview-3233596607
More information about the hotspot-dev
mailing list