RFR: 8367325: [s390x] build failure due to JDK-8361376 [v2]

[Martin Doerr]

On Wed, 17 Sep 2025 06:01:37 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> src/hotspot/cpu/s390/gc/shared/barrierSetNMethod_s390.cpp line 43:
>> 
>>> 41:       address inst_addr = get_barrier_start_address() + BarrierSetAssembler::PATCHABLE_INSTRUCTION_OFFSET;
>>> 42: 
>>> 43:       DEBUG_ONLY(Assembler::is_z_cfi(*((long*)inst_addr)));
>> 
>> The cfi check needs an adjustment to point to the instruction start, right?
>
> Now It is pointing to `z_cfi`: 
> 
> 
> (gdb) x/i inst_addr 
>    0x3ffe500017a:	cfi	%r0,0

This line looks broken (already before this PR). Shouldn't it be something like `assert(Assembler::is_z_cfi...)`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27213#discussion_r2354998084