RFR: 8366716: Move SmapsParser from runtime/os/TestTracePageSizes.java into testlib [v3]
Stefan Johansson
sjohanss at openjdk.org
Wed Sep 17 16:47:43 UTC 2025
On Mon, 15 Sep 2025 12:51:40 GMT, jonghoonpark <duke at openjdk.org> wrote:
>> related jira issue: https://bugs.openjdk.org/browse/JDK-8366716
>>
>> ---
>>
>> Following the direction outlined in the issue description,
>> I've extracted the common parts from `TestTracePageSizes` and `TestTransparentHugePagesHeap` to implement the `SmapsParser` test library.
>>
>> I've confirmed that it works without issues in my local tests.
>>
>> Reviews and feedback are welcome.
>
> jonghoonpark has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>
> Refactor: Introduce Smaps class for testing
>
> Signed-off-by: jonghoonpark <dev at jonghoonpark.com>
Found some time to look closer at this. I would prefer if we could clean up the `Smaps` class even more when moving it to the testlib. We might want to go even further than this:
https://github.com/openjdk/jdk/compare/master...kstefanj:jdk:pull/27273-v2
I felt it was easier to show you my ideas this way rather than just giving comment. Some names might need improving and some more polishing, but what do you think about the general structure [here](https://github.com/openjdk/jdk/commit/4550eb677d74803935be64a1cc321c671f91adc7)?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/27273#issuecomment-3303806697
More information about the hotspot-dev
mailing list