RFR: 8360651: Create OSContainer API for memory limit [v2]
Stefan Johansson
sjohanss at openjdk.org
Thu Sep 18 06:38:53 UTC 2025
On Mon, 8 Sep 2025 17:54:10 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:
>> Please review this small addition to add a new `OSContainer::has_memory_limit()` API (Linux only - as with the entire OSContainer API) in preparation for [JDK-8350596](https://bugs.openjdk.org/browse/JDK-8350596) which proposes to increase the default `MaxRAMPercentage` when this new API returns true. The patch is pretty trivial. It's only the testing which amounts to the most lines in this patch.
>>
>> Testing:
>> - [x] GHA
>> - [x] Hotspot container tests on x86_64 Linux on cgroup v1 and cgroup v2 (including the new tests).
>>
>> Thoughts?
>
> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>
> - Merge branch 'master' into jdk-8360651-mem-limit-api
> - MemoryLimitTest whitespace fixes.
> - TestContainerMemory whitespace fixes.
> - 8360651: Create OSContainer API for memory limit
Is it correct to only look at `memory_limit_in_bytes()`? We also have `memory_and_swap_limit_in_bytes()` and `memory_soft_limit_in_bytes()`.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/26020#issuecomment-3305624187
More information about the hotspot-dev
mailing list