RFR: 8367249: [REDO] MemBaseline accesses VMT without using lock [v5]
Afshin Zafari
azafari at openjdk.org
Thu Sep 18 08:25:16 UTC 2025
On Wed, 17 Sep 2025 15:42:10 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:
>> Hi,
>>
>> This is a REDO, as the previous attempt caused build failures when merged with latest master.
>> The only difference is that the copy ctr for the RBTRee had been integrated with a different PR, but it never should have been. I deleted the copy ctr.
>>
>> Thanks.
>
> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>
> How did this even work in any release build?
The changes in `VMATree::copy_into` of this PR, are only seen if we test/check the allocation_sites after a baseline. As I checked the gTest/JTREG tests, none of them check the sites that is written out to the report. So, the code for `copy_into` is never run in release builds and no allocation_site will be stored in a baseline nor written out in the report. No test will check it to discover it.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/27170#issuecomment-3306125209
More information about the hotspot-dev
mailing list