RFR: 8367325: [s390x] build failure due to JDK-8361376 [v5]

[Amit Kumar]

On Thu, 18 Sep 2025 12:26:09 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update
>
> src/hotspot/cpu/s390/gc/shared/barrierSetNMethod_s390.cpp line 54:
> 
>> 52: 
>> 53:   public:
>> 54:     static const int BARRIER_TOTAL_LENGTH = BarrierSetAssembler::BARRIER_TOTAL_LENGTH;
> 
> Is it necessary to replicate it?

It is being used with `NativeMethodBarrier`, yes I can change it and technically it wouldn't affect anything, but just to keep code change bit shorter, I left it as it is.

> src/hotspot/cpu/s390/gc/shared/barrierSetNMethod_s390.cpp line 98:
> 
>> 96:         offset += Assembler::instr_len(&start[offset]);
>> 97: 
>> 98:         // it will be assignment operation, So it doesn't matter what value is already present in instr
> 
> I don't understand what you mean by "it will be assignment operation".

it is just a assignment being done in that method, i.e. `instr` variable will be just overwritten straightly. So currently whatever value `instr` holds, it wouldn't not affect the returned-value.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27213#discussion_r2359026137
PR Review Comment: https://git.openjdk.org/jdk/pull/27213#discussion_r2359038854