RFR: 8367536: Change RBTree to use C++17 features [v3]

Casper Norrbin cnorrbin at openjdk.org
Thu Sep 18 13:45:26 UTC 2025


On Wed, 17 Sep 2025 21:30:19 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> Maybe leave a comment with `has_not_verifier` about the issue, referring to that gcc bug? Oh, and `has_node_verifier` is a type, so should normally be studly capped. Add an "Impl" suffix to avoid collision with the constant, and also make it more obvious other code shouldn't be referencing it directly.

Thank you for the comment. It's unfortunate that such a bug exists, and that we had to encounter it almost immediately. I can definitely understand why it wasn't caught though. Seeing as it is pretty niche, I agree it shouldn't be added to the style guide at this time, perhaps in the future if it were to become a (somewhat) regular problem. Nevertheless, I pushed an update to document the issue (with the GCC PR ID) in the code along with changing the struct name to `HasNodeVerifierImpl`.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/27260#issuecomment-3307538098


More information about the hotspot-dev mailing list