RFR: 8367325: [s390x] build failure due to JDK-8361376 [v5]

Dean Long dlong at openjdk.org
Thu Sep 18 23:29:50 UTC 2025


On Thu, 18 Sep 2025 12:09:31 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> Fixes the SIGLL caused after [JDK-8361376](https://bugs.openjdk.org/browse/JDK-8361376). 
>> 
>> Issue was with `cs` instruction, which requires the address to be aligned. And after this change address at which operating was not aligned.
>> 
>> Wisdom from Principle of Z Operations: 
>> 
>> Sytax: CS R<sub>1</sub>,R<sub>3</sub>,D<sub>2</sub>(B<sub>2</sub>)
>> 
>> Sytax: CSY R<sub>1</sub>,R<sub>3</sub>,D<sub>2</sub>(B<sub>2</sub>)
>> 
>> `
>> The second operand of COMPARE AND SWAP (CS, CSY) must be designated on a word boundary.
>> `
>> 
>> 
>> 
>> => 0x3fffc3149ba <_ZN17BarrierSetNMethod15set_guard_valueEP7nmethodii+266>: cs %r1,%r4,0(%r3)
>> (gdb) i r r3
>> r3             0x3ffe500017a       4397593526650
>> (gdb) p ($r3 % 8) 
>> $5 = 2
>> (gdb) si 
>> 
>> Thread 16 "C1 CompilerThre" received signal SIGILL, Illegal instruction.
>> NativeMethodBarrier::set_guard_value (bit_mask=2147483647, value=1, this=0x3ffe5000166)
>>     at /home/amit/jdk/src/hotspot/cpu/s390/gc/shared/barrierSetNMethod_s390.cpp:74
>> 74         if (v == old_value) break;
>
> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update

Looks reasonable to me.

-------------

Marked as reviewed by dlong (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/27213#pullrequestreview-3242337049


More information about the hotspot-dev mailing list