RFR: 8368072: Remove redundant arguments of MarkingNMethodClosure [v2]

Francesco Andreuzzi fandreuzzi at openjdk.org
Fri Sep 19 08:18:42 UTC 2025


On Fri, 19 Sep 2025 08:15:24 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> "Inline" statically known value to callee to simplify `MarkingNMethodClosure`.
>> 
>> Test: tier1
>
> Albert Mingkun Yang has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - review
>  - review

src/hotspot/share/memory/iterator.hpp line 261:

> 259:  public:
> 260:   MarkingNMethodClosure(OopClosure* cl) :
> 261:       NMethodToOopClosure(cl, false /* fix_relocations */) {}

Would it be appropriate to use `!NMethodToOopClosure::FixRelocations` here instead?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27382#discussion_r2362127076


More information about the hotspot-dev mailing list