RFR: 8367862: debug.cpp: Do not print help message for methods ifdef'd out [v2]

[Manuel Hässig]

On Fri, 19 Sep 2025 10:37:18 GMT, Kerem Kat <krk at openjdk.org> wrote:

>> The `help` command in `debug.cpp` was out of date, listing only a fraction of the available functions. This and other commands callable from gdb via `call help()`.
>> 
>> I added all commands to the help message, except `pns2` as it is documented as not being useful when called from gdb.
>> 
>> Also fixed is the message for the conditional `pns` command appearing in PRODUCT builds.
>
> Kerem Kat has updated the pull request incrementally with one additional commit since the last revision:
> 
>   address comments

Thank you for addressing my comments, @krk. You missed one "s" (see below), otherwise this looks good to me.

src/hotspot/share/utilities/debug.cpp line 687:

> 685:   tty->print_cr("method metadata.");
> 686:   tty->print_cr("  blob(CodeBlob* p)      - print CodeBlob");
> 687:   tty->print_cr("  dump_vtable(address p) - dumps vtable of the Klass");

Suggestion:

  tty->print_cr("  dump_vtable(address p) - dump vtable of the Klass");

-------------

Marked as reviewed by mhaessig (Committer).

PR Review: https://git.openjdk.org/jdk/pull/27341#pullrequestreview-3250904144
PR Review Comment: https://git.openjdk.org/jdk/pull/27341#discussion_r2366937608