RFR: 8367989: Remove InstanceKlass::allocate_objArray and ArrayKlass::allocate_arrayArray [v3]

Stefan Karlsson stefank at openjdk.org
Mon Sep 22 07:33:08 UTC 2025


On Fri, 19 Sep 2025 13:18:09 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This change removes InstanceKlass::allocate_objArray and has its caller call ObjArrayKlass::allocate_instance directly from oopFactory, like the other array allocations do.  See CR for more information why we should have this change.  I also removed element_klass_addr() and moved element_klass_offset() to be in a more logical place near element_klass() functions.  This upstreams a tiny valhalla diff.
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use virtual function rather than if statement, still need one cast though.

This looks good to me. Please test this thoroughly given the complexity inside the called functions.

-------------

Marked as reviewed by stefank (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/27372#pullrequestreview-3250956254


More information about the hotspot-dev mailing list