RFR: 8366905: Store AdapterBlob pointer in AdapterHandlerEntry [v3]
Andrew Dinn
adinn at openjdk.org
Mon Sep 22 10:32:03 UTC 2025
On Mon, 22 Sep 2025 10:09:00 GMT, Andrew Dinn <adinn at openjdk.org> wrote:
>> Ashutosh Mehra has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Add missing ResourceMark
>>
>> Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
>
> src/hotspot/share/oops/method.cpp line 1290:
>
>> 1288: } else if (_adapter == nullptr) {
>> 1289: (void) make_adapters(h_method, CHECK);
>> 1290: #ifndef ZERO
>
> With your change to sharedRuntime_zero.cpp I believe the preceding call to `make_adapters` will hit `ShouldNotReachHere()` and hence will not return. So, this #ifndef ZERO appears to be unnecessary.
Ok, scratch that. I see that `generate_adapter_code` bypasses the call to `generate_i2c2i_adapters` in the ZERO case.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27101#discussion_r2367518481
More information about the hotspot-dev
mailing list