RFR: 8367103: RISC-V: store cpu features in a bitmap [v5]

Ludovic Henry luhenry at openjdk.org
Mon Sep 22 10:33:04 UTC 2025


On Mon, 22 Sep 2025 09:22:39 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Hi,
>> Can you help to review this patch?
>> 
>> Currently, the cpu features of riscv are stored in separate RVFeature subclasses.
>> But to support the store/restore CPU features for aot in the future, we need to store the cpu features in a continuous memory.
>> As the riscv extensions are introduced continuously, I think it's better to do it via an simple bitmap at the beginning.
>> Currently, just suppose the non-extension features will not be stored in aot image, so I also split the extension and non-extenion features. When we implement the related aot feature in the short future, we can revisit the way of splitting the features. Currently, just change the storage way of cpu features, lay the foundation for future aot.
>> 
>> Thanks
>
> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   simplify names

src/hotspot/cpu/riscv/vm_version_riscv.hpp line 415:

> 413:   // Null terminated list
> 414:   static RVFeatureValue* _feature_list[];
> 415:   static RVExtFeatures* _rv_ext_features;

Does that need to be a pointer? Can't it be `static RVExtFeatures _rv_ext_features` directly?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27152#discussion_r2367519227


More information about the hotspot-dev mailing list