RFR: 8367103: RISC-V: store cpu features in a bitmap [v5]

Hamlin Li mli at openjdk.org
Mon Sep 22 10:38:20 UTC 2025


On Mon, 22 Sep 2025 10:26:03 GMT, Ludovic Henry <luhenry at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   simplify names
>
> src/hotspot/cpu/riscv/vm_version_riscv.hpp line 68:
> 
>> 66:     }
>> 67:     const char* pretty()         { return _pretty; }
>> 68:     uint64_t feature_bit()       { return _linux_feature_bit; }
> 
> Why the renaming?

Two reasons:
1. There is another field `_cpu_feature_index` introduced in `RVExtFeatureValue`.
2. the `_feature_bit ` here is indeed linux feature rather cpu features.

So, to be precise and avoid confusing, it's better to rename it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27152#discussion_r2367549901


More information about the hotspot-dev mailing list