RFR: 8368124: Show useful thread names in ASAN reports [v4]
David Holmes
dholmes at openjdk.org
Wed Sep 24 01:18:11 UTC 2025
On Tue, 23 Sep 2025 15:28:02 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>>
>> review feedback
>
> src/hotspot/os/linux/os_linux.cpp line 4868:
>
>> 4866: // set name in kernel
>> 4867: int rc = prctl(PR_SET_NAME, buf);
>> 4868: assert(rc == 0, "prctl(PR_SET_NAME) failed");
>
> shouldn't we check also the return code rc in release builds and not only assert ?
I don't think so. If this "fails" what could we do? This should not be presented as a failure to the end user.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27395#discussion_r2373809809
More information about the hotspot-dev
mailing list