RFR: 8367103: RISC-V: store cpu features in a bitmap [v4]

Hamlin Li mli at openjdk.org
Wed Sep 24 10:51:52 UTC 2025


On Mon, 22 Sep 2025 07:12:25 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix typo
>
> src/hotspot/cpu/riscv/vm_version_riscv.hpp line 305:
> 
>> 303: 
>> 304:     static uint64_t bit_mask(RVFeatureIndex feature) {
>> 305:       return (1ULL << (feature & features_bitmap_element_mask()));
> 
> The two functions `features_bitmap_element_mask` and `bit_mask` look very confusing to me. Is it better to factor out `features_bitmap_element_mask` and rename this `bit_mask` into something like `features_bitmap_element_bit_mask`?

I misunderstood this, thought it's the similar suggestion as the below one.
Will make it more readable here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27152#discussion_r2375356196


More information about the hotspot-dev mailing list