RFR: 8367103: RISC-V: store cpu features in a bitmap [v7]

Hamlin Li mli at openjdk.org
Wed Sep 24 15:55:02 UTC 2025


On Wed, 24 Sep 2025 15:30:31 GMT, Ludovic Henry <luhenry at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove explicit cpu feature index in RV_EXT_FEATURE_FLAGS
>
> src/hotspot/cpu/riscv/vm_version_riscv.hpp line 248:
> 
>> 246:   static NAME##RVExtFeatureValue NAME;                                                  \
>> 247: 
>> 248:   RV_EXT_FEATURE_FLAGS(DECLARE_RV_EXT_FEATURE)
> 
> Maybe an `#undef DECLARE_RV_EXT_FEATURE` after that line?

fixed

> src/hotspot/cpu/riscv/vm_version_riscv.hpp line 268:
> 
>> 266:   static NAME##RVNonExtFeatureValue NAME;                                          \
>> 267: 
>> 268:   RV_NON_EXT_FEATURE_FLAGS(DECLARE_RV_NON_EXT_FEATURE)
> 
> It would be good to `#undef DECLARE_RV_NON_EXT_FEATURE` right after that.

fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27152#discussion_r2376269034
PR Review Comment: https://git.openjdk.org/jdk/pull/27152#discussion_r2376269184


More information about the hotspot-dev mailing list