RFR: 8367692: RISC-V: Align post call nop [v2]

[Robbin Ehn]

On Thu, 25 Sep 2025 01:45:08 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Merge branch 'master' into align_post_nops
>>  - Review comments
>>  - init
>
> src/hotspot/cpu/riscv/assembler_riscv.hpp line 859:
> 
>> 857:     return insn;
>> 858:   }
>> 859: 
> 
> I am not sure but is it better to place this with friends `encode_jal` and `encode_jalr` at line 928? These all return an instruction encoding instead of writing the code cache and thus are different from other assember routines. Maybe we should group them together.

Fixed

> src/hotspot/cpu/riscv/sharedRuntime_riscv.cpp line 1007:
> 
>> 1005:     __ bnez(c_rarg2, call_thaw);
>> 1006: 
>> 1007:     address tr_call;
> 
> Can you rename this to `call_pc` while you are on it? `tr_call` is named after trampoline call, but we don't have that now.

Fixed

> src/hotspot/cpu/riscv/sharedRuntime_riscv.cpp line 1042:
> 
>> 1040:   __ bnez(c_rarg2, call_thaw);
>> 1041: 
>> 1042:   address tr_call;
> 
> Similar here.

Fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27467#discussion_r2378234720
PR Review Comment: https://git.openjdk.org/jdk/pull/27467#discussion_r2378235050
PR Review Comment: https://git.openjdk.org/jdk/pull/27467#discussion_r2378235359