RFR: 8367485: os::physical_memory is broken in 32-bit JVMs when running on 64-bit OSes [v12]
Severin Gehwolf
sgehwolf at openjdk.org
Thu Sep 25 09:59:08 UTC 2025
On Thu, 25 Sep 2025 09:53:32 GMT, Anton Artemov <duke at openjdk.org> wrote:
>> Hi, please consider the following changes:
>>
>> In this PR we address the overflow issue in `os::physical_memory()` on Linux, which can occur when running a 32-bit JVM on a 64-bit machine, introduced by https://bugs.openjdk.org/browse/JDK-8357086. The problem is that the product of _SC_PHYS_PAGES and _SC_PAGESIZE can overflow according to the documentation.
>>
>> The issue is addressed by changing the output type of all related functions to `physical_memory_size_type`, which is an alias to `uint64_t`.
>>
>> Tested in tiers 1 - 5.
>
> Anton Artemov has updated the pull request incrementally with two additional commits since the last revision:
>
> - 8367485: Fixed whitespace error.
> - 8367485: Added print formar for mem funcs vals.
Looks good to me.
-------------
Marked as reviewed by sgehwolf (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/27335#pullrequestreview-3266833425
More information about the hotspot-dev
mailing list