RFR: 8367485: os::physical_memory is broken in 32-bit JVMs when running on 64-bit OSes [v13]
Albert Mingkun Yang
ayang at openjdk.org
Thu Sep 25 15:52:53 UTC 2025
On Thu, 25 Sep 2025 14:47:34 GMT, Joel Sikström <jsikstro at openjdk.org> wrote:
>> Anton Artemov has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - 8367485: Fixed new line after typedef.
>> - 8367485: Fixed comment in global definitions.
>
> src/hotspot/share/utilities/globalDefinitions.hpp line 423:
>
>> 421: // This typedef is to address the issue of running a 32-bit VM on a 64-bit platform. In this case
>> 422: // the amount of physical memory may not fit in size_t, so we have to have a larger type. Once 32-bit
>> 423: // is depricated, one can use size_t.
>
> It's not only 32-bit VM on a 64-bit platform, it's 32-bit VM in general, since we can have an issue on both: 1) a 64-bit platform, and 2) a 32-bit (ARM) platform with LPAE enabled.
Typo: "depricated".
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27335#discussion_r2379615341
More information about the hotspot-dev
mailing list