RFR: 8367253: RISC-V: refactor dependent cpu extensions [v6]
Hamlin Li
mli at openjdk.org
Mon Sep 29 09:00:05 UTC 2025
> Hi,
> Can you help to review this patch?
>
> Dependent extensions could be improved in several ways.
>
> Currently, the dependent cpu extensions are processed in 2 separate places:
> 1. update_flag() when calling VM_Version::setup_cpu_available_features()
> 2. at the end of VM_Version::common_initialize().
>
> And, dependency relationship can only be expressed in (1:1) way, can not be expressed (1:N) way, but in fact some extensions can depend on several different other extensions, for example, zvfh depends on zvf and rvv. It's would be better to support this (1:N) relationship.
>
> So, this PR brings several benefits:
> 1. VM options directly related to CPU extensions are automatically set, and they are all set in one place.
> 2. keep synchronization between CPU extensions (information in RVFeatureValue) and and VM options. Previously, code in common_initialize wont' sync to RVFeatureValue, unless do it manually, which is error-prone.
> 3. support to express (1:N) dependency relationship among cpu extensions and related vm options.
>
> Thanks!
>
>
> ## Test
>
>
> $TEST_JDK/bin/java -XX:+UnlockExperimentalVMOptions -XX:-UseRVV -XX:+PrintFlagsFinal -version | grep -e UseRVV -e UseZvbc -e UseZvfh -e UseZvkn
> OpenJDK 64-Bit Server VM warning: Cannot enable UseZvbb on cpu without any of the supports: v (disabled)
> OpenJDK 64-Bit Server VM warning: Cannot enable UseZvbc on cpu without any of the supports: v (disabled)
> OpenJDK 64-Bit Server VM warning: Cannot enable UseZvfh on cpu without any of the supports: v (disabled), Zfh (enabled)
> bool UseRVV = false {ARCH diagnostic} {command line}
> bool UseZvbc = false {ARCH experimental} {default}
> bool UseZvfh = false {ARCH diagnostic} {default}
> bool UseZvkn = false {ARCH experimental} {default}
>
>
>
> $TEST_JDK/bin/java -XX:+UnlockExperimentalVMOptions -XX:-UseZfh -XX:+PrintFlagsFinal -version | grep -e UseRVV -e UseZvbc -e UseZvfh -e UseZvkn
> OpenJDK 64-Bit Server VM warning: Cannot enable UseZvfh on cpu without any of the supports: v (enabled), Zfh (disabled)
> bool UseRVV = true {ARCH diagnostic} {default}
> bool UseZvbc = true {ARCH experimental} {default}
> bool UseZvfh ...
Hamlin Li has updated the pull request incrementally with two additional commits since the last revision:
- remove ResourceMark
- verify_deps
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/27171/files
- new: https://git.openjdk.org/jdk/pull/27171/files/0dd9f9c3..25b6dc87
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=27171&range=05
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=27171&range=04-05
Stats: 17 lines in 2 files changed: 0 ins; 17 del; 0 mod
Patch: https://git.openjdk.org/jdk/pull/27171.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/27171/head:pull/27171
PR: https://git.openjdk.org/jdk/pull/27171
More information about the hotspot-dev
mailing list