RFR: 8365047: Remove exception handler stub code in C2 [v5]

Ruben duke at openjdk.org
Mon Sep 29 09:48:11 UTC 2025


On Fri, 26 Sep 2025 12:56:32 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

> Should we rename `entry_point` to `entry_offset` in the deopt handlers to emphasize that it's an offset and not a pointer?

Sure. I will do that.

> src/hotspot/share/code/nmethod.cpp line 3:
> 
>> 1: /*
>> 2:  * Copyright (c) 1997, 2025, Oracle and/or its affiliates. All rights reserved.
>> 3:  * Copyright 2025 Arm Limited and/or its affiliates.
> 
> Still questionable, here. Do we have clear guidelines?

Thanks for the feedback. I followed the current guideline at https://openjdk.org/guide/#copyright-headers which advises:

> If your affiliation doesn’t have a copyright notice, again consult your legal representative to see if you should add one.

If the guideline isn't applicable or if there is a more detailed guidance on when Copyright header should or should not be added, I'd appreciate further advice.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/26678#issuecomment-3346006871
PR Review Comment: https://git.openjdk.org/jdk/pull/26678#discussion_r2387339188


More information about the hotspot-dev mailing list