RFR: 8365047: Remove exception handler stub code in C2 [v5]

Martin Doerr mdoerr at openjdk.org
Mon Sep 29 10:39:33 UTC 2025


On Mon, 29 Sep 2025 09:45:40 GMT, Ruben <duke at openjdk.org> wrote:

>> src/hotspot/share/code/nmethod.cpp line 3:
>> 
>>> 1: /*
>>> 2:  * Copyright (c) 1997, 2025, Oracle and/or its affiliates. All rights reserved.
>>> 3:  * Copyright 2025 Arm Limited and/or its affiliates.
>> 
>> Still questionable, here. Do we have clear guidelines?
>
> Thanks for the feedback. I followed the current guideline at https://openjdk.org/guide/#copyright-headers which advises:
> 
>> If your affiliation doesn’t have a copyright notice, again consult your legal representative to see if you should add one.
> 
> If the guideline isn't applicable or if there is a more detailed guidance on when Copyright header should or should not be added, I'd appreciate further advice.

Here are some arguments why I wouldn't do it:
- We usually don't add Copyright headers to existing files. Only to new ones we created. Many contributors are doing the same AFAIK. (Maybe only for very significant contributions to a file.)
- The Linux Foundation has listed reasons "Why not list every copyright holder?" https://www.linuxfoundation.org/blog/blog/copyright-notices-in-open-source-software-projects
- OpenJDK headers say "DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER."

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26678#discussion_r2387477511


More information about the hotspot-dev mailing list