RFR: 8367692: RISC-V: Align post call nop [v6]

Robbin Ehn rehn at openjdk.org
Mon Sep 29 12:41:03 UTC 2025


On Mon, 29 Sep 2025 10:09:39 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>> 
>>  - Merge branch 'master' into align_post_nops
>>  - Use relocation spec as marker.
>>  - Revert "Removed relocate for post call nops"
>>    
>>    This reverts commit 033ecd4ab3d62c1ccc7845d8bc9e62fc6574e05d.
>>  - Removed relocate for post call nops
>>  - Merge branch 'master' into align_post_nops
>>  - Review comments
>>  - init
>
> src/hotspot/cpu/riscv/macroAssembler_riscv.cpp line 363:
> 
>> 361:     return;
>> 362:   }
>> 363:   relocate(post_call_nop_Relocation::spec());
> 
> What's the reason for this change? Does it make difference from the previous code?

The code is location inpedent, meaning it will be the exact same encoding regardless of what addresses it's placed on. But we need a reloc spec to keep track of where we did place them.
So we don't need to regenerate the instructions after move.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27467#discussion_r2387789861


More information about the hotspot-dev mailing list