RFR: 8367253: RISC-V: refactor dependent cpu extensions [v5]

Hamlin Li mli at openjdk.org
Mon Sep 29 21:28:33 UTC 2025


On Mon, 29 Sep 2025 08:55:58 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> src/hotspot/cpu/riscv/vm_version_riscv.hpp line 103:
>> 
>>> 101:     }
>>> 102: 
>>> 103:     void verify_deps(RVFeatureValue* dep0, ...) {
>> 
>> Not used anywhere?
>
> Thanks for catching! I'll just remove it in this pr.
> 
> It should have been added in `UPDATE_DEFAULT_DEP(flag, dep0, ...)`, to do the similar work as the assert at https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/riscv/vm_version_riscv.hpp#L92. But seems previous way (introduced in https://github.com/openjdk/jdk/pull/24094) does not work as expected to catch declarations out of dependend orders, `verify_deps` does not catch it either as it inherits the way in the pr 24094.
> 
> I'll investigate it later and fix it in another pr.

I don't think the previous assert introduced in https://github.com/openjdk/jdk/pull/24094 is necessary.
So we are good to just remove the related code.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27171#discussion_r2389310449


More information about the hotspot-dev mailing list