RFR: 8368897: RISC-V: Cleanup RV_EXT_FEATURE_FLAGS & RV_NON_EXT_FEATURE_FLAGS
Fei Yang
fyang at openjdk.org
Tue Sep 30 03:05:45 UTC 2025
On Mon, 29 Sep 2025 21:37:49 GMT, Hamlin Li <mli at openjdk.org> wrote:
> Hi,
> Can you help to review the patch?
>
> This patch cleans up RV_EXT_FEATURE_FLAGS & RV_NON_EXT_FEATURE_FLAGS, as discussed https://github.com/openjdk/jdk/pull/27152#discussion_r2367109820:
> * reorder flags in alphabetic order for RV_EXT_FEATURE_FLAGS
> * move comments close to feature declaration for RV_EXT_FEATURE_FLAGS & RV_NON_EXT_FEATURE_FLAGS
>
> We also discussed (https://github.com/openjdk/jdk/pull/27171#discussion_r2387195562) the assert introduced in https://github.com/openjdk/jdk/pull/24094, previously we think this will restrict the flags order in RV_EXT_FEATURE_FLAGS, but I found out that this assert is not necessary, so we should be able to order flags in RV_EXT_FEATURE_FLAGS in any way we'd like to.
>
> Thanks!
Hi, You need merge and rebase :-) But the order of the detection of these extesions still matters, right? Say we must detect `ext_v` before `ext_Zvbb`.
-------------
PR Review: https://git.openjdk.org/jdk/pull/27562#pullrequestreview-3282416140
More information about the hotspot-dev
mailing list