RFR: 8368897: RISC-V: Cleanup RV_EXT_FEATURE_FLAGS & RV_NON_EXT_FEATURE_FLAGS [v2]

Hamlin Li mli at openjdk.org
Tue Sep 30 10:09:58 UTC 2025


On Tue, 30 Sep 2025 09:32:28 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Hi,
>> Can you help to review the patch?
>> 
>> This patch cleans up RV_EXT_FEATURE_FLAGS & RV_NON_EXT_FEATURE_FLAGS, as discussed https://github.com/openjdk/jdk/pull/27152#discussion_r2367109820:
>> * reorder flags in alphabetic order for RV_EXT_FEATURE_FLAGS
>> * move comments close to feature declaration for RV_EXT_FEATURE_FLAGS & RV_NON_EXT_FEATURE_FLAGS
>> 
>> We also discussed (https://github.com/openjdk/jdk/pull/27171#discussion_r2387195562) the assert introduced in https://github.com/openjdk/jdk/pull/24094, previously we think this will restrict the flags order in RV_EXT_FEATURE_FLAGS, but I found out that this  assert (<del>is not necessary</del>, so we should be able to order flags in RV_EXT_FEATURE_FLAGS in any way we'd like to) does not work as expected, will fix this in another pr.
>> 
>> Thanks!
>
> Hamlin Li has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits:
> 
>  - merge master
>  - Merge branch 'openjdk:master' into master
>  - initial commit
>  - Merge branch 'openjdk:master' into master
>  - Merge branch 'openjdk:master' into master
>  - Merge branch 'openjdk:master' into master
>  - Merge branch 'openjdk:master' into master
>  - Merge branch 'openjdk:master' into master
>  - Merge branch 'openjdk:master' into master
>  - Merge branch 'openjdk:master' into master
>  - ... and 1 more: https://git.openjdk.org/jdk/compare/c0a4c0ba...247b63d9

I file https://bugs.openjdk.org/browse/JDK-8368950 to track the out of order declarations in RV_FEATURE_FLAGS.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/27562#issuecomment-3351098223


More information about the hotspot-dev mailing list