RFR: 8328306: AArch64: MacOS lazy JIT "write xor execute" switching [v3]
Andrew Haley
aph at openjdk.org
Tue Sep 30 13:47:25 UTC 2025
On Fri, 15 Aug 2025 01:09:18 GMT, Dean Long <dlong at openjdk.org> wrote:
>> Andrew Haley has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp
>>
>> Co-authored-by: Dean Long <17332032+dean-long at users.noreply.github.com>
>
> src/hotspot/share/runtime/javaCalls.cpp line 330:
>
>> 328:
>> 329: JavaThread* thread = THREAD;
>> 330: MACOS_AARCH64_ONLY(ThreadWXEnable wx(WXExec, THREAD));
>
> JavaCallWrapper::JavaCallWrapper() is already calling enable_wx(WXExec), and JavaCallWrapper::~JavaCallWrapper() is calling enable_wx(WXWrite), so we have double coverage. Can we remove the calls from JavaCallWrapper and just keep this one, and maybe move it down closer to the StubRoutines::call_stub()?
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26562#discussion_r2391540275
More information about the hotspot-dev
mailing list