RFR: 8372942: AArch64: Set JVM flags for Neoverse V3AE core [v2]

Ruben duke at openjdk.org
Mon Feb 2 12:42:26 UTC 2026


On Wed, 14 Jan 2026 09:02:33 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Thanks, this is fine.
>> I wonder if we should be thinking about replacing some of this open-coded logic with something more expressive and concise. This bunch of model_is() expressions could be a switch, for example.
>
>> Thank you for review, @theRealAph,
>> 
>> > I wonder if we should be thinking about replacing some of this open-coded logic with something more expressive and concise. This bunch of model_is() expressions could be a switch, for example.
>> 
>> While switch-case might not be easily applicable because we have two variables, both of which have to be compared with the values,
> 
> I only see one here, the `model_is`.
> 
>> perhaps an interface like `bool is_model_any_of(std::initializer_list list)` can simplify the code. Would this approach be suitable?
> 
> Maybe, if it's made as simple as possible.
> 
>> Would you like this to be changed within this PR?
> 
> I think so.

@theRealAph, 

> I'm thinking of bool is_model_any_of(std::initializer_list<int> list) which would iterate over the list and call model_is for each candidate

I've added this as `model_is_in` interface. Does the new implementation look suitable?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28607#issuecomment-3834887509


More information about the hotspot-dev mailing list