RFR: 8375443: AVX-512: Disabling through UseSHA doesn't affect UseSHA3Intrinsics [v5]

Vladimir Kozlov kvn at openjdk.org
Tue Feb 3 19:22:43 UTC 2026


On Tue, 3 Feb 2026 10:54:33 GMT, Ramkumar Sunderbabu <rsunderbabu at openjdk.org> wrote:

>> UseSHA flag is not respected while enabling/disabling UseSHA3Intrinsics flag in x86 builds.
>> Added UseSHA in the mix.
>
> Ramkumar Sunderbabu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixed whitespace issue

SHA code here is mess. I would like it be re-written similar to what we have for `UseAES`.

Is only x86 code affected or other platforms have it too?

Also look on [PR 29338](https://git.openjdk.org/jdk/pull/29338)

src/hotspot/cpu/x86/vm_version_x86.cpp line 1346:

> 1344:     if (FLAG_IS_DEFAULT(UseSHA3Intrinsics)) {
> 1345:       FLAG_SET_DEFAULT(UseSHA3Intrinsics, true);
> 1346:       UseSHA3Intrinsics = true;

You don't need this line - `FLAG_SET_DEFAULT` sets it.

-------------

PR Review: https://git.openjdk.org/jdk/pull/29266#pullrequestreview-3747105520
PR Review Comment: https://git.openjdk.org/jdk/pull/29266#discussion_r2760610604


More information about the hotspot-dev mailing list